[
https://issues.apache.org/jira/browse/STORM-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002661#comment-15002661
]
ASF GitHub Bot commented on STORM-1030:
---------------------------------------
Github user dossett commented on a diff in the pull request:
https://github.com/apache/storm/pull/871#discussion_r44699532
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
collector.ack(t);
tupleBatch.clear();
}
+ } catch(SerializationError se) {
+ LOG.info("Serialization exception occurred, tuple is
acknowledged but not written to Hive.", tuple);
+ collector.ack(tuple);
--- End diff --
Yeah, I think right try/catch blocks improve readability greatly but that
may be a style preference. Would a call to collector.reporterror also be
appropriate in that catch?
On Thu, Nov 12, 2015 at 8:44 AM Harsha <[email protected]> wrote:
> In
> external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java
> <https://github.com/apache/storm/pull/871#discussion_r44680811>:
>
> > @@ -134,22 +131,16 @@ public void execute(Tuple tuple) {
> > collector.ack(t);
> > tupleBatch.clear();
> > }
> > + } catch(SerializationError se) {
> > + LOG.info("Serialization exception occurred, tuple is
acknowledged but not written to Hive.", tuple);
> > + collector.ack(tuple);
>
> @revans2 <https://github.com/revans2> makes sense. I'll add the metric
> and update the patch. Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/storm/pull/871/files#r44680811>.
>
> Hive Connector Fixes
> --------------------
>
> Key: STORM-1030
> URL: https://issues.apache.org/jira/browse/STORM-1030
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hive
> Reporter: Sriharsha Chintalapani
> Assignee: Sriharsha Chintalapani
> Fix For: 0.11.0
>
>
> 1. Schedule Hive transaction heartbeats outside of execute method.
> 2. Fix retiring idleWriters
> 3. Do not call flush if there is no data added to a txnbatch
> 4. Catch any exception and abort transaction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
