[ 
https://issues.apache.org/jira/browse/STORM-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018335#comment-15018335
 ] 

ASF GitHub Bot commented on STORM-1198:
---------------------------------------

Github user jerrypeng commented on a diff in the pull request:

    https://github.com/apache/storm/pull/875#discussion_r45491671
  
    --- Diff: storm-core/src/jvm/backtype/storm/scheduler/Cluster.java ---
    @@ -461,6 +466,75 @@ public SupervisorDetails getSupervisorById(String 
nodeId) {
             return networkTopography;
         }
     
    +    /*
    +    * Get heap memory usage for a worker's main process and logwriter 
process
    +    * */
    +    private Double getAssignedMemoryForSlot(Map topConf) {
    +        Double totalWorkerMemory = 0.0;
    +
    +        String topology_worker_childopts = 
Utils.getString(topConf.get(Config.TOPOLOGY_WORKER_CHILDOPTS), null);
    --- End diff --
    
    I think we should use camel case to be consistent with rest of the file


> Web UI to show resource usages and Total Resources on all supervisors
> ---------------------------------------------------------------------
>
>                 Key: STORM-1198
>                 URL: https://issues.apache.org/jira/browse/STORM-1198
>             Project: Apache Storm
>          Issue Type: Story
>          Components: storm-core
>            Reporter: Zhuo Liu
>            Assignee: Zhuo Liu
>            Priority: Minor
>         Attachments: supervisor-resources.png
>
>
> As we have resource aware scheduler (STORM-894), we want to be able to 
> display resource capacity (CPU, memory; and network in future) and scheduled 
> resource usage on each supervisor node.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to