[ 
https://issues.apache.org/jira/browse/STORM-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018618#comment-15018618
 ] 

ASF GitHub Bot commented on STORM-1198:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/875#discussion_r45508355
  
    --- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
    @@ -764,5 +778,30 @@ public static long zipFileSize(File myFile) throws 
IOException{
         public static double zeroIfNaNOrInf(double x) {
             return (Double.isNaN(x) || Double.isInfinite(x)) ? 0.0 : x;
         }
    +
    +    /**
    +     * parses the arguments to extract jvm heap memory size.
    +     * @param input
    +     * @param defaultValue
    +     * @return the value of the JVM heap memory setting in a java command.
    +     */
    +    public static Double parseWorkerChildOpts(String input, Double 
defaultValue) {
    --- End diff --
    
    I would prefer to have the name of this function indicate what it is 
parsing out of the childopts.


> Web UI to show resource usages and Total Resources on all supervisors
> ---------------------------------------------------------------------
>
>                 Key: STORM-1198
>                 URL: https://issues.apache.org/jira/browse/STORM-1198
>             Project: Apache Storm
>          Issue Type: Story
>          Components: storm-core
>            Reporter: Zhuo Liu
>            Assignee: Zhuo Liu
>            Priority: Minor
>         Attachments: supervisor-resources.png
>
>
> As we have resource aware scheduler (STORM-894), we want to be able to 
> display resource capacity (CPU, memory; and network in future) and scheduled 
> resource usage on each supervisor node.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to