[
https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018731#comment-15018731
]
ASF GitHub Bot commented on STORM-885:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45515312
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/StormServerHandler.java ---
@@ -25,33 +26,39 @@
import org.jboss.netty.channel.SimpleChannelUpstreamHandler;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.util.List;
import java.util.concurrent.atomic.AtomicInteger;
-class StormServerHandler extends SimpleChannelUpstreamHandler {
+public class StormServerHandler extends SimpleChannelUpstreamHandler {
private static final Logger LOG =
LoggerFactory.getLogger(StormServerHandler.class);
- Server server;
+ IServer server;
private AtomicInteger failure_count;
+ private Channel channel;
- StormServerHandler(Server server) {
+ public StormServerHandler(IServer server) {
this.server = server;
failure_count = new AtomicInteger(0);
}
@Override
public void channelConnected(ChannelHandlerContext ctx,
ChannelStateEvent e) {
- server.addChannel(e.getChannel());
+ server.channelConnected(e.getChannel());
+ if(channel != null) {
+ LOG.debug("Replacing channel with new channel: "
+ + channel.toString() + " -> " +
e.getChannel().toString());
--- End diff --
Use format string for log message
> Heartbeat Server (Pacemaker)
> ----------------------------
>
> Key: STORM-885
> URL: https://issues.apache.org/jira/browse/STORM-885
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Kyle Nusbaum
>
> Large highly connected topologies and large clusters write a lot of data into
> ZooKeeper. The heartbeats, that make up the majority of this data, do not
> need to be persisted to disk. Pacemaker is intended to be a secure
> replacement for storing the heartbeats without changing anything within the
> heartbeats. In the future as more metrics are added in, we may want to look
> into switching it over to look more like Heron, where a metrics server is
> running for each node/topology. And can be used to aggregate/per-aggregate
> them in a more scalable manor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
