[
https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018751#comment-15018751
]
ASF GitHub Bot commented on STORM-885:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/838#discussion_r45516042
--- Diff:
storm-core/src/jvm/org/apache/storm/pacemaker/PacemakerClient.java ---
@@ -0,0 +1,252 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.pacemaker;
+
+import backtype.storm.Config;
+import backtype.storm.generated.HBMessage;
+import backtype.storm.messaging.netty.Client;
+import backtype.storm.messaging.netty.ISaslClient;
+import backtype.storm.messaging.netty.NettyRenameThreadFactory;
+import backtype.storm.security.auth.AuthUtils;
+import backtype.storm.utils.StormBoundedExponentialBackoffRetry;
+import java.net.InetSocketAddress;
+import java.util.Map;
+import java.util.Timer;
+import java.util.TimerTask;
+import java.util.concurrent.Executors;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicReference;
+import javax.security.auth.login.Configuration;
+import org.apache.storm.pacemaker.codec.ThriftNettyClientCodec;
+import org.jboss.netty.bootstrap.ClientBootstrap;
+import org.jboss.netty.channel.Channel;
+import org.jboss.netty.channel.ChannelPipelineFactory;
+import org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class PacemakerClient implements ISaslClient {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(PacemakerClient.class);
+
+ private String topo_name;
+ private String secret;
+ private boolean ready = false;
+ private final ClientBootstrap bootstrap;
+ private AtomicReference<Channel> channelRef;
+ private AtomicBoolean closing;
+ private InetSocketAddress remote_addr;
+ private int maxPending = 100;
+ private HBMessage messages[];
+ private LinkedBlockingQueue<Integer> availableMessageSlots;
+ private ThriftNettyClientCodec.AuthMethod authMethod;
+
+ private StormBoundedExponentialBackoffRetry backoff = new
StormBoundedExponentialBackoffRetry(100, 5000, 20);
+ private int retryTimes = 0;
+
+ public PacemakerClient(Map config) {
+
+ String host = (String)config.get(Config.PACEMAKER_HOST);
+ int port = (int)config.get(Config.PACEMAKER_PORT);
+ topo_name = (String)config.get(Config.TOPOLOGY_NAME);
+ if(topo_name == null) {
+ topo_name = "pacemaker-client";
+ }
+
+ String auth = (String)config.get(Config.PACEMAKER_AUTH_METHOD);
+ ThriftNettyClientCodec.AuthMethod authMethod;
+
+ if(auth.equals("DIGEST")) {
--- End diff --
This series of `if ... else if` can be a `switch`.
> Heartbeat Server (Pacemaker)
> ----------------------------
>
> Key: STORM-885
> URL: https://issues.apache.org/jira/browse/STORM-885
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Kyle Nusbaum
>
> Large highly connected topologies and large clusters write a lot of data into
> ZooKeeper. The heartbeats, that make up the majority of this data, do not
> need to be persisted to disk. Pacemaker is intended to be a secure
> replacement for storing the heartbeats without changing anything within the
> heartbeats. In the future as more metrics are added in, we may want to look
> into switching it over to look more like Heron, where a metrics server is
> running for each node/topology. And can be used to aggregate/per-aggregate
> them in a more scalable manor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
