[
https://issues.apache.org/jira/browse/STORM-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041621#comment-15041621
]
ASF GitHub Bot commented on STORM-1345:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/922#issuecomment-161985154
@Parth-Brahmbhatt how far along is this patch with testing/work? I see a
lot of commented out code in the pull request and I am having a little bit of
difficulty understanding why. There is also at least one big TODO in the code.
Could you please either remove the unneeded code or explain what the next
steps are to use it and to deal with the TODO?
Also could you give a brief overview of the design of this. From looking
at the code, including the commented out sections, it appears that the
intentions is to upload a new jar, config, and/or topology layout. Then
rebalance the topology to have it rescheduled. The supervisors also now look
at a new topology version field to see if they should kill/restart the worker
or not. Is that correct?
The blob store feature moves the conf, topology, and topology-jar into the
blob store which also supports doing dynamic updates within the supervisor. I
think it would be a lot cleaner if we could try and leverage this functionality.
I also agree with @unsleepy22 that there are several types of updates, and
going off of your TODO in the code I think there are several different ways we
want to potentially update a topology. There are changes that require a
restart of the worker and ones that do not (but may require changes to the
system/user code to allow this). There are also changes that should be done as
a rolling upgrade, one worker at a time, to allow for minimal impact, but there
are others that are so big that you are killing off the topology and just
restarting it again, but keeping the ID for some reason.
I am fine with this being a first step where we only support a single type
of update, which is the most generic of them. You can change anything and we
will restart the entire topology as quickly as possible. But I would like to
understand you view about where this feature ultimately ends up.
> Thrift, nimbus ,zookeeper, supervisor and worker changes to support update
> topology.
> ------------------------------------------------------------------------------------
>
> Key: STORM-1345
> URL: https://issues.apache.org/jira/browse/STORM-1345
> Project: Apache Storm
> Issue Type: Sub-task
> Components: storm-core
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
