[ 
https://issues.apache.org/jira/browse/STORM-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042152#comment-15042152
 ] 

ASF GitHub Bot commented on STORM-1345:
---------------------------------------

Github user Parth-Brahmbhatt commented on the pull request:

    https://github.com/apache/storm/pull/922#issuecomment-162069596
  
    @revans2 @unsleepy22 I did not know Jstorm has it and hasn't had a chance 
to look at the dist cache. 
    
    My goal was to allow users to update topology or config or jar and support 
workers being restarted in a rolling fashion, When the topology it self is 
changed we can still do rolling restart and that is the part where I have a 
TODO that I need to finish. 
    
    I thought all of those required workers to bounce, I am not sure which 
parts can work without bouncing the worker. 
    
    The code I have commented is about making update a state just like 
rebalance/kill/activate and I am still not convinced that it needs to be a 
state of its own.
    
    I am fine with waiting till we are done with JStorm integration as long as 
JStorm achieves the same goals.   If others think that this is an important 
enough feature that we should include in the release before we do a feature 
lockdown, I can upmerge with dist cache and use it as @revans2  suggested.


> Thrift, nimbus ,zookeeper, supervisor and worker changes to support update 
> topology.
> ------------------------------------------------------------------------------------
>
>                 Key: STORM-1345
>                 URL: https://issues.apache.org/jira/browse/STORM-1345
>             Project: Apache Storm
>          Issue Type: Sub-task
>          Components: storm-core
>            Reporter: Parth Brahmbhatt
>            Assignee: Parth Brahmbhatt
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to