[
https://issues.apache.org/jira/browse/STORM-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058837#comment-15058837
]
ASF GitHub Bot commented on STORM-898:
--------------------------------------
Github user rfarivar commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47699315
--- Diff:
storm-core/test/jvm/backtype/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java
---
@@ -0,0 +1,293 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package backtype.storm.scheduler.resource;
+
+import backtype.storm.Config;
+import backtype.storm.generated.Bolt;
+import backtype.storm.generated.SpoutSpec;
+import backtype.storm.generated.StormTopology;
+import backtype.storm.generated.TopologySummary;
+import backtype.storm.scheduler.ExecutorDetails;
+import backtype.storm.scheduler.INimbus;
+import backtype.storm.scheduler.IScheduler;
+import backtype.storm.scheduler.SupervisorDetails;
+import backtype.storm.scheduler.Topologies;
+import backtype.storm.scheduler.TopologyDetails;
+import backtype.storm.scheduler.WorkerSlot;
+import backtype.storm.spout.SpoutOutputCollector;
+import backtype.storm.task.OutputCollector;
+import backtype.storm.task.TopologyContext;
+import backtype.storm.topology.BoltDeclarer;
+import backtype.storm.topology.OutputFieldsDeclarer;
+import backtype.storm.topology.SpoutDeclarer;
+import backtype.storm.topology.TopologyBuilder;
+import backtype.storm.topology.base.BaseRichBolt;
+import backtype.storm.topology.base.BaseRichSpout;
+import backtype.storm.tuple.Fields;
+import backtype.storm.tuple.Tuple;
+import backtype.storm.tuple.Values;
+import backtype.storm.utils.Time;
+import backtype.storm.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import java.util.Random;
+import java.util.Set;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+public class TestUtilsForResourceAwareScheduler {
+ private static final Logger LOG =
LoggerFactory.getLogger(TestUtilsForResourceAwareScheduler.class);
+
+ public static List<TopologyDetails> getListOfTopologies(Config config)
{
+
+ List<TopologyDetails> topos = new LinkedList<TopologyDetails>();
+
+ topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-1",
config, 5, 15, 1, 1, Time.currentTimeSecs() - 2, 20));
+ topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-2",
config, 5, 15, 1, 1, Time.currentTimeSecs() - 8, 30));
+ topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-3",
config, 5, 15, 1, 1, Time.currentTimeSecs() - 16, 30));
+ topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-4",
config, 5, 15, 1, 1, Time.currentTimeSecs() - 16, 20));
+ topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-5",
config, 5, 15, 1, 1, Time.currentTimeSecs() - 24, 30));
+ topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-6",
config, 5, 15, 1, 1, Time.currentTimeSecs() - 2, 0));
+ topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-7",
config, 5, 15, 1, 1, Time.currentTimeSecs() - 8, 0));
+ topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-8",
config, 5, 15, 1, 1, Time.currentTimeSecs() - 16, 15));
+ topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-9",
config, 5, 15, 1, 1, Time.currentTimeSecs() - 16, 8));
+
topos.add(TestUtilsForResourceAwareScheduler.getTopology("topo-10", config, 5,
15, 1, 1, Time.currentTimeSecs() - 24, 9));
+ return topos;
+ }
+
+ public static List<String> getListOfTopologiesCorrectOrder() {
+ List<String> topos = new LinkedList<String>();
+ topos.add("topo-7");
+ topos.add("topo-6");
+ topos.add("topo-9");
+ topos.add("topo-10");
+ topos.add("topo-8");
+ topos.add("topo-4");
+ topos.add("topo-1");
+ topos.add("topo-5");
+ topos.add("topo-3");
+ topos.add("topo-2");
+ return topos;
+ }
+
+ public static Map<String, SupervisorDetails> genSupervisors(int
numSup, int numPorts, Map resourceMap) {
+ Map<String, SupervisorDetails> retList = new HashMap<String,
SupervisorDetails>();
+ for (int i = 0; i < numSup; i++) {
+ List<Number> ports = new LinkedList<Number>();
+ for (int j = 0; j < numPorts; j++) {
+ ports.add(j);
+ }
+ SupervisorDetails sup = new SupervisorDetails("sup-" + i,
"host-" + i, null, ports, resourceMap);
+ retList.put(sup.getId(), sup);
+ }
+ return retList;
+ }
+
+ public static Map<ExecutorDetails, String>
genExecsAndComps(StormTopology topology, int spoutParallelism, int
boltParallelism) {
+ Map<ExecutorDetails, String> retMap = new HashMap<ExecutorDetails,
String>();
+ int startTask = 0;
+ int endTask = 1;
+ for (Map.Entry<String, SpoutSpec> entry :
topology.get_spouts().entrySet()) {
+ for (int i = 0; i < spoutParallelism; i++) {
+ retMap.put(new ExecutorDetails(startTask, endTask),
entry.getKey());
+ startTask++;
+ endTask++;
+ }
+ }
+
+ for (Map.Entry<String, Bolt> entry :
topology.get_bolts().entrySet()) {
+ for (int i = 0; i < boltParallelism; i++) {
+ retMap.put(new ExecutorDetails(startTask, endTask),
entry.getKey());
+ startTask++;
+ endTask++;
+ }
+ }
+ return retMap;
+ }
+
+ public static TopologyDetails getTopology(String name, Map config, int
numSpout, int numBolt,
+ int spoutParallelism, int
boltParallelism, int launchTime, int priority) {
+
+ Config conf = new Config();
+ conf.putAll(config);
+ conf.put(Config.TOPOLOGY_PRIORITY, priority);
+ conf.put(Config.TOPOLOGY_NAME, name);
+ conf.put(Config.TOPOLOGY_WORKER_MAX_HEAP_SIZE_MB,
Double.MAX_VALUE);
+ StormTopology topology = buildTopology(numSpout, numBolt,
spoutParallelism, boltParallelism);
+ TopologyDetails topo = new TopologyDetails(name + "-" +
launchTime, conf, topology,
+ 0,
+ genExecsAndComps(topology, spoutParallelism,
boltParallelism), launchTime);
+ return topo;
+ }
+
+ public static StormTopology buildTopology(int numSpout, int numBolt,
+ int spoutParallelism, int
boltParallelism) {
+ LOG.debug("buildTopology with -> numSpout: " + numSpout + "
spoutParallelism: "
+ + spoutParallelism + " numBolt: "
+ + numBolt + " boltParallelism: " + boltParallelism);
+ TopologyBuilder builder = new TopologyBuilder();
+
+ for (int i = 0; i < numSpout; i++) {
+ SpoutDeclarer s1 = builder.setSpout("spout-" + i, new
TestSpout(),
+ spoutParallelism);
+ }
+ int j = 0;
+ for (int i = 0; i < numBolt; i++) {
+ if (j >= numSpout) {
+ j = 0;
+ }
+ BoltDeclarer b1 = builder.setBolt("bolt-" + i, new TestBolt(),
+ boltParallelism).shuffleGrouping("spout-" + j);
+ }
+
+ return builder.createTopology();
+ }
+
+ public static class TestSpout extends BaseRichSpout {
+ boolean _isDistributed;
+ SpoutOutputCollector _collector;
+
+ public TestSpout() {
+ this(true);
+ }
+
+ public TestSpout(boolean isDistributed) {
+ _isDistributed = isDistributed;
+ }
+
+ public void open(Map conf, TopologyContext context,
SpoutOutputCollector collector) {
+ _collector = collector;
+ }
+
+ public void close() {
+
--- End diff --
empty line.
> Add priorities and per user resource guarantees to Resource Aware Scheduler
> ---------------------------------------------------------------------------
>
> Key: STORM-898
> URL: https://issues.apache.org/jira/browse/STORM-898
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Boyang Jerry Peng
> Attachments: Resource Aware Scheduler for Storm.pdf
>
>
> In a multi-tenant environment we would like to be able to give individual
> users a guarantee of how much CPU/Memory/Network they will be able to use in
> a cluster. We would also like to know which topologies a user feels are the
> most important to keep running if there are not enough resources to run all
> of their topologies.
> Each user should be able to specify if their topology is production, staging,
> or development. Within each of those categories a user should be able to give
> a topology a priority, 0 to 10 with 10 being the highest priority (or
> something like this).
> If there are not enough resources on a cluster to run a topology assume this
> topology is running using resources and find the user that is most over their
> guaranteed resources. Shoot the lowest priority topology for that user, and
> repeat until, this topology is able to run, or this topology would be the one
> shot. Ideally we don't actually shoot anything until we know that we would
> have made enough room.
> If the cluster is over-subscribed and everyone is under their guarantee, and
> this topology would not put the user over their guarantee. Shoot the lowest
> priority topology in this workers resource pool until there is enough room to
> run the topology or this topology is the one that would be shot. We might
> also want to think about what to do if we are going to shoot a production
> topology in an oversubscribed case, and perhaps we can shoot a non-production
> topology instead even if the other user is not over their guarantee.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
