GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1016
Storm 1450
Code refactored:
1. Refactor RAS_Nodes. Pushed some of the functionality in to RAS_Nodes.
Each RAS_Node will now be initialized with a map of all its assignments. Each
RAS_Node will also figure out resources used and available. Removed unnecessary
functions.
2. Made WorkerSlot immutable so that a scheduling strategy won't mistakenly
modify it
3. Added a wrapping layer for RAS_Node to feed into scheduling strategies
so that the semantics of what a scheduling strategy should do will be more
clear. Each scheduling strategy shouldn't be actually assigning anything. The
strategy should only calculate a scheduling.
Bug fixes:
1. Minor bug in displaying the assigned resources for a supervisor on the
UI. The function updateSupervisorResources was placed in the wrong place
2. Minor bug fix in freeing memory in RAS_Node there was some wrong math
that was done.
Added Additional unit tests to test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-1450
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1016.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1016
----
commit 829ea117c8b382ef72d3c5df841534b89f06dffa
Author: Boyang Jerry Peng <[email protected]>
Date: 2016-01-13T18:28:38Z
[STORM-1450] - Fix bugs and refactor code in ResourceAwareScheduler
commit 688366902d98a7fdc17d854a33ff975c6a60ccab
Author: Boyang Jerry Peng <[email protected]>
Date: 2016-01-13T20:13:54Z
adding an additional test and cleaning up
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
