Github user zhuoliu commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1016#discussion_r49785382
  
    --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/Cluster.java ---
    @@ -662,22 +662,50 @@ public void setStatusMap(Map<String, String> 
statusMap) {
             this.status.putAll(statusMap);
         }
     
    -    public void setResources(String topologyId, Double[] resources) {
    -        this.resources.put(topologyId, resources);
    +    /**
    +     * Set the amount of resources used used by a topology. Used for 
displaying resource information on the UI
    +     * @param topologyId
    +     * @param resources describes the resources requested and assigned to 
topology in the following format in an array:
    +     *  {requestedMemOnHeap, requestedMemOffHeap, requestedCpu, 
assignedMemOnHeap, assignedMemOffHeap, assignedCpu}
    +     */
    +    public void setTopologyResources(String topologyId, Double[] 
resources) {
    --- End diff --
    
    Yep, I think that would be helpful. Both for topology and supervisor 
resources. We may file a separate JIRA for that or do it within this pull 
request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to