Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1043#discussion_r50893250
  
    --- Diff: 
storm-core/src/clj/org/apache/storm/cluster_state/zookeeper_state_factory.clj 
---
    @@ -90,7 +91,7 @@
            (if (zk/exists zk-writer path false)
              (zk/set-data zk-writer path data)
              (do
    -           (zk/mkdirs zk-writer (parent-path path) acls)
    +           (zk/mkdirs zk-writer (Utils/parentPath path) acls)
    --- End diff --
    
    Like I said in #1045 there are some path manipulation functions that look 
like they belong in a Zookeeper.java file not in Utils.java.  Please work with 
them to figure out how to move them, even if it is in a follow on JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to