Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50893939
--- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
@@ -178,18 +201,25 @@
(.set_enable (get options :enable false))
(.set_samplingpct (get options :samplingpct 10))))
+;TODO: when translating this function, you should replace the map-val with
a proper for loop HERE
(defn thriftify-storm-base [storm-base]
(doto (StormBase.)
(.set_name (:storm-name storm-base))
(.set_launch_time_secs (int (:launch-time-secs storm-base)))
(.set_status (convert-to-status-from-symbol (:status storm-base)))
(.set_num_workers (int (:num-workers storm-base)))
+ ;(.set_component_executors (Utils/mapVal (reify IFn (eval [this x]
(int x))) (:component->executors storm-base)))
(.set_component_executors (map-val int (:component->executors
storm-base)))
(.set_owner (:owner storm-base))
(.set_topology_action_options (thriftify-topology-action-options
storm-base))
(.set_prev_status (convert-to-status-from-symbol (:prev-status
storm-base)))
+; (.set_component_debug
+; (Utils/mapVal
+; (reify IFn (eval [this x] (thriftify-debugoptions x)))
+; (:component->debug storm-base)))))
--- End diff --
And these too. Please delete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
