Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50894663
--- Diff: storm-core/src/clj/org/apache/storm/local_state.clj ---
@@ -104,17 +105,24 @@
(->executor-list (.get_executors thrift-local-assignment))
(.get_resources thrift-local-assignment)))
+;TODO: when translating this function, you should replace the map-val with
a proper for loop HERE
(defn ls-local-assignments!
[^LocalState local-state assignments]
- (let [local-assignment-map (map-val ->LocalAssignment assignments)]
- (.put local-state LS-LOCAL-ASSIGNMENTS
+ (let [local-assignment-map (map-val ->LocalAssignment assignments)]
+; (let [local-assignment-map (Utils/mapVal
+; (reify IFn (eval [this x]
(->LocalAssignment x)))
+; assignments)]
--- End diff --
Please remove commented out code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
