Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50992981
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -288,11 +289,11 @@
(defmacro with-inprocess-zookeeper
[port-sym & body]
`(with-local-tmp [tmp#]
- (let [[~port-sym zks#] (zk/mk-inprocess-zookeeper tmp#)]
+ (let [[~port-sym zks#] (Zookeeper/mkInprocessZookeeper
tmp# nil)]
--- End diff --
This is not a drop in replacement because mkInprocessZookeeper is returning
just zks# not ~port-sym. You might be able to make this work by changing it to.
```
(let [zks# (Zookeeper/mkInprocessZookeeper tmp# nil)
~port-sym (.getLocalPort zks#)]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
