Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1047#discussion_r50993291
  
    --- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
    @@ -134,7 +135,7 @@
     (defnk mk-local-storm-cluster [:supervisors 2 :ports-per-supervisor 3 
:daemon-conf {} :inimbus nil :supervisor-slot-port-min 1024 :nimbus-daemon 
false]
       (let [zk-tmp (local-temp-path)
             [zk-port zk-handle] (if-not (contains? daemon-conf 
STORM-ZOOKEEPER-SERVERS)
    -                              (zk/mk-inprocess-zookeeper zk-tmp))
    +                              (Zookeeper/mkInprocessZookeeper zk-tmp nil))
    --- End diff --
    
    This also needs to be updated similarly to below.
    
    ```
    (let [zk-tmp (local-temp-path)
           zk-handle (if-not (contains? daemon-conf STORM-ZOOKEEPER-SERVERS)
                              (Zookeeper/mkInprocessZookeeper zk-tmp nil))
           zk-port (.getLocalPort zk-handle)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to