[
https://issues.apache.org/jira/browse/STORM-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119344#comment-15119344
]
ASF GitHub Bot commented on STORM-1257:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1047#discussion_r50992981
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -288,11 +289,11 @@
(defmacro with-inprocess-zookeeper
[port-sym & body]
`(with-local-tmp [tmp#]
- (let [[~port-sym zks#] (zk/mk-inprocess-zookeeper tmp#)]
+ (let [[~port-sym zks#] (Zookeeper/mkInprocessZookeeper
tmp# nil)]
--- End diff --
This is not a drop in replacement because mkInprocessZookeeper is returning
just zks# not ~port-sym. You might be able to make this work by changing it to.
```
(let [zks# (Zookeeper/mkInprocessZookeeper tmp# nil)
~port-sym (.getLocalPort zks#)]
```
> port backtype.storm.zookeeper to java
> -------------------------------------
>
> Key: STORM-1257
> URL: https://issues.apache.org/jira/browse/STORM-1257
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: John Fang
> Labels: java-migration, jstorm-merger
>
> A wrapper around zookeeper/curator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
