[ 
https://issues.apache.org/jira/browse/STORM-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119353#comment-15119353
 ] 

ASF GitHub Bot commented on STORM-1257:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1047#discussion_r50993291
  
    --- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
    @@ -134,7 +135,7 @@
     (defnk mk-local-storm-cluster [:supervisors 2 :ports-per-supervisor 3 
:daemon-conf {} :inimbus nil :supervisor-slot-port-min 1024 :nimbus-daemon 
false]
       (let [zk-tmp (local-temp-path)
             [zk-port zk-handle] (if-not (contains? daemon-conf 
STORM-ZOOKEEPER-SERVERS)
    -                              (zk/mk-inprocess-zookeeper zk-tmp))
    +                              (Zookeeper/mkInprocessZookeeper zk-tmp nil))
    --- End diff --
    
    This also needs to be updated similarly to below.
    
    ```
    (let [zk-tmp (local-temp-path)
           zk-handle (if-not (contains? daemon-conf STORM-ZOOKEEPER-SERVERS)
                              (Zookeeper/mkInprocessZookeeper zk-tmp nil))
           zk-port (.getLocalPort zk-handle)
    ```


> port backtype.storm.zookeeper to java
> -------------------------------------
>
>                 Key: STORM-1257
>                 URL: https://issues.apache.org/jira/browse/STORM-1257
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: John Fang
>              Labels: java-migration, jstorm-merger
>
> A wrapper around zookeeper/curator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to