[
https://issues.apache.org/jira/browse/STORM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121511#comment-15121511
]
ASF GitHub Bot commented on STORM-1506:
---------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1051#issuecomment-176198148
While Utils.getInt(Object) does provide safe conversion, this PR forces
type conversion, which breaks unit tests (Nimbus crashed).
Please see https://travis-ci.org/apache/storm/jobs/105184033 and
https://travis-ci.org/apache/storm/jobs/105184034.
We can find the reason of ClassCastException from
http://clojuredocs.org/clojure.core/type, type of number literal is actually
Long in Clojure.
We may want to consider Clojure unless porting is complete.
> It's better to be Integer about port of
> STORM_ZOOKEEPER_PORT&TRANSACTIONAL_ZOOKEEPER_PORT
> -------------------------------------------------------------------------------------------
>
> Key: STORM-1506
> URL: https://issues.apache.org/jira/browse/STORM-1506
> Project: Apache Storm
> Issue Type: Wish
> Reporter: John Fang
> Assignee: John Fang
> Priority: Minor
>
> It's better to replace Object by Integer about port of
> STORM_ZOOKEEPER_PORT&TRANSACTIONAL_ZOOKEEPER_PORT
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
