[
https://issues.apache.org/jira/browse/STORM-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121544#comment-15121544
]
ASF GitHub Bot commented on STORM-1506:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1051#issuecomment-176204284
@hustfxj, I probably was not clear enough in my review comments that
spawned this JIRA. I was thinking along the lines of @HeartSaVioR. Once the
majority of the code is in java we can review types everywhere. I wanted this
JIRA filed so it is one that we do not forget about. If you can make all of
the tests pass before the full java conversion I am OK with it, but like
@HeartSaVioR said you will need to update the clojure code to go from a long
which is the clojure default to a int explicitly.
> It's better to be Integer about port of
> STORM_ZOOKEEPER_PORT&TRANSACTIONAL_ZOOKEEPER_PORT
> -------------------------------------------------------------------------------------------
>
> Key: STORM-1506
> URL: https://issues.apache.org/jira/browse/STORM-1506
> Project: Apache Storm
> Issue Type: Wish
> Reporter: John Fang
> Assignee: John Fang
> Priority: Minor
>
> It's better to replace Object by Integer about port of
> STORM_ZOOKEEPER_PORT&TRANSACTIONAL_ZOOKEEPER_PORT
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
