Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1071#discussion_r51726152
--- Diff:
storm-core/src/clj/org/apache/storm/pacemaker/pacemaker_state_factory.clj ---
@@ -47,7 +43,7 @@
(reify
ClusterState
;; Let these pass through to the zk-state. We only want to handle
heartbeats.
- (register [this callback] (.register zk-state callback))
+ (register [this callback] (.register zk-state callback)) ; need
update callback, have questions?? callback is IFn here
--- End diff --
If the callback takes a defined set of parameters that are used
consistently lets either create or reuse an interface and then wrap the
callback function in a reify call to create an instance of the interface for
the callback to talk to.
If it does not take any parameters, it just is a function that is triggered
than make it a Runnable. But I think in this case it is the former, not the
latter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
