Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1071#discussion_r51726849
--- Diff: storm-core/src/jvm/org/apache/storm/callback/Callback.java ---
@@ -18,6 +18,9 @@
package org.apache.storm.callback;
+import clojure.lang.IFn;
+
+// To remove IFn after porting all callbacks to java
public interface Callback {
public <T> Object execute(T... args);
--- End diff --
I don't like this interface. The generic <T> for the parameters is just
confusing because it implies that all of the parameters should be of the same
type, when in reality they are not. I would much rather see something like
```
public interface ZKStateChangedCallback {
public void changed(Watcher.Event.EventType type, String path);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
