[
https://issues.apache.org/jira/browse/STORM-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130457#comment-15130457
]
ASF GitHub Bot commented on STORM-1273:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1071#discussion_r51726152
--- Diff:
storm-core/src/clj/org/apache/storm/pacemaker/pacemaker_state_factory.clj ---
@@ -47,7 +43,7 @@
(reify
ClusterState
;; Let these pass through to the zk-state. We only want to handle
heartbeats.
- (register [this callback] (.register zk-state callback))
+ (register [this callback] (.register zk-state callback)) ; need
update callback, have questions?? callback is IFn here
--- End diff --
If the callback takes a defined set of parameters that are used
consistently lets either create or reuse an interface and then wrap the
callback function in a reify call to create an instance of the interface for
the callback to talk to.
If it does not take any parameters, it just is a function that is triggered
than make it a Runnable. But I think in this case it is the former, not the
latter.
> port backtype.storm.cluster to java
> -----------------------------------
>
> Key: STORM-1273
> URL: https://issues.apache.org/jira/browse/STORM-1273
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> current state of the cluster (Some of this moves to java as a part of
> heartbeat server)
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster
> as an example
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
