[
https://issues.apache.org/jira/browse/STORM-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130465#comment-15130465
]
ASF GitHub Bot commented on STORM-1273:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1071#discussion_r51726849
--- Diff: storm-core/src/jvm/org/apache/storm/callback/Callback.java ---
@@ -18,6 +18,9 @@
package org.apache.storm.callback;
+import clojure.lang.IFn;
+
+// To remove IFn after porting all callbacks to java
public interface Callback {
public <T> Object execute(T... args);
--- End diff --
I don't like this interface. The generic <T> for the parameters is just
confusing because it implies that all of the parameters should be of the same
type, when in reality they are not. I would much rather see something like
```
public interface ZKStateChangedCallback {
public void changed(Watcher.Event.EventType type, String path);
}
```
> port backtype.storm.cluster to java
> -----------------------------------
>
> Key: STORM-1273
> URL: https://issues.apache.org/jira/browse/STORM-1273
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> current state of the cluster (Some of this moves to java as a part of
> heartbeat server)
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster
> as an example
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
