[
https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133782#comment-15133782
]
ASF GitHub Bot commented on STORM-1492:
---------------------------------------
GitHub user HeartSaVioR reopened a pull request:
https://github.com/apache/storm/pull/1082
STORM-1492 With nimbus.seeds set to default, a nimbus for localhost may
appear "Offline"
First of all, AFAIK, it's just an issue of API output, and it doesn't hurt
functionality although we don't fix it.
* when determining nimbus addresses from nimbus.seeds, filter out localhost
addresses
* localhost address: 127.0.0.1, localhost, 0:0:0:0:0:0:0:1
* there may be a chance that nimbus (localhost) is not reachable so we
can't get info from alive-nimbuses
* but it means ui process itself can't reach nimbus so we can ignore this
case
* there may be another change that user writes nimbus.seeds both
unreachable localhost address and other reachable nimbuses fqdn
* ui process can reach other nimbus and localhost itself is lost
* but I think we can treat it as configuration error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1492
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1082.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1082
----
commit 125fd47a7c428e5747ca2cb11fe31ad129311aa3
Author: Jungtaek Lim <kabh...@gmail.com>
Date: 2016-02-05T06:40:16Z
STORM-1492 With nimbus.seeds set to default, a nimbus for localhost may
appear "Offline"
* when determining nimbus addresses from nimbus.seeds, filter out localhost
addresses
* localhost address: 127.0.0.1, localhost, 0:0:0:0:0:0:0:1
* there may be a chance that nimbus (localhost) is not reachable so we
can't get info from alive-nimbuses
* but it means ui process itself can't reach nimbus so we can ignore this
case
* there may be another change that user writes nimbus.seeds both
unreachable localhost address and other reachable nimbuses fqdn
* ui process can reach other nimbus and localhost itself is lost
* but I think we can treat it as configuration error
----
> With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"
> -----------------------------------------------------------------------------
>
> Key: STORM-1492
> URL: https://issues.apache.org/jira/browse/STORM-1492
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: P. Taylor Goetz
> Assignee: Jungtaek Lim
> Priority: Minor
>
> With the default value for {{nimbus.seeds}} ({{["localhost"]}}) Storm UI may
> list one "Offline" nimbus for localhost, and another as "Leader" for the
> resolved machine name.
> Steps to reproduce (assumes ZK is running; all on local machine):
> 1. Clean install of 1.0.0-SNAPSHOT (do not modify {{storm.yaml}})
> 2. Start nimbus
> 3. Start supervisor
> 4. Start ui
> 5. Navigate to http://localhost:8080
> A workaround is to modify {{storm.yaml}} and replace "localhost" with the
> hostname of the machine in {{nimbus.seeds}}.
> While trivial to correct, this may confuse users. One approach is to simply
> document this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
