[
https://issues.apache.org/jira/browse/STORM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169450#comment-15169450
]
ASF GitHub Bot commented on STORM-1492:
---------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1082#issuecomment-189401885
@wuchong
You're right. Actually this PR just tries to address weird behavior when
users leave the setting to default.
Btw, there're more to cover if we want to address this to more ideal way.
For example, canonical host name for each machine can be overwritten by
setting storm.local.hostname.
Please refer NimbusConf#fromConf for details.
In result, every nimbuses should know what's the return value of
NimbusConf#fromConf for other nimbuses, and every nimbuses should match
nimbus.seeds and corresponding values by 1 on 1.
I don't have an idea how to do it for now, and I really appreciate ideas
which address this.
Otherwise users should describe the same value which NimbusConf#fromConf
will return, for nimbus.seeds.
> With nimbus.seeds set to default, a nimbus for localhost may appear "Offline"
> -----------------------------------------------------------------------------
>
> Key: STORM-1492
> URL: https://issues.apache.org/jira/browse/STORM-1492
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: P. Taylor Goetz
> Assignee: Jungtaek Lim
> Priority: Minor
>
> With the default value for {{nimbus.seeds}} ({{["localhost"]}}) Storm UI may
> list one "Offline" nimbus for localhost, and another as "Leader" for the
> resolved machine name.
> Steps to reproduce (assumes ZK is running; all on local machine):
> 1. Clean install of 1.0.0-SNAPSHOT (do not modify {{storm.yaml}})
> 2. Start nimbus
> 3. Start supervisor
> 4. Start ui
> 5. Navigate to http://localhost:8080
> A workaround is to modify {{storm.yaml}} and replace "localhost" with the
> hostname of the machine in {{nimbus.seeds}}.
> While trivial to correct, this may confuse users. One approach is to simply
> document this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
