Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52076438
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.container.cgroup;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.BufferedReader;
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileReader;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+public class CgroupUtils {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(CgroupUtils.class);
+
+ public static void deleteDir(String dir) {
+ File d = new File(dir);
+ if (d.exists()) {
+ if (d.isDirectory()) {
+ if (!d.delete()) {
+ throw new RuntimeException("Cannot delete dir " + dir);
+ }
+ } else {
+ throw new RuntimeException("dir " + dir + " is not a
directory!");
+ }
+ } else {
+ LOG.warn("dir {} does not exist!", dir);
+ }
+ }
+
+ public static boolean fileExists(String dir) {
+ File file = new File(dir);
+ return file.exists();
+ }
+
+ public static boolean dirExists(String dir) {
+ File file = new File(dir);
+ return file.isDirectory();
+ }
+
+ public static Set<SubSystemType> analyse(String str) {
+ Set<SubSystemType> result = new HashSet<SubSystemType>();
+ String[] subSystems = str.split(",");
+ for (String subSystem : subSystems) {
+ SubSystemType type = SubSystemType.getSubSystem(subSystem);
+ if (type != null) {
+ result.add(type);
+ }
+ }
+ return result;
+ }
+
+ public static String reAnalyse(Set<SubSystemType> subSystems) {
+ StringBuilder sb = new StringBuilder();
+ if (subSystems.size() == 0) {
+ return sb.toString();
+ }
+ for (SubSystemType type : subSystems) {
+ sb.append(type.name()).append(",");
+ }
+ return sb.toString().substring(0, sb.length() - 1);
+ }
+
+ public static boolean enabled() {
+ return CgroupUtils.fileExists(Constants.CGROUP_STATUS_FILE);
+ }
+
+ public static List<String> readFileByLine(String fileDir) throws
IOException {
+ List<String> result = new ArrayList<String>();
+ File file = new File(fileDir);
+ try (FileReader fileReader = new FileReader(file);
+ BufferedReader reader = new BufferedReader(fileReader)) {
+ String tempString = null;
+ while ((tempString = reader.readLine()) != null) {
+ result.add(tempString);
+ }
+ }
+ return result;
+ }
+
+ public static void writeFileByLine(String fileDir, List<String>
strings) throws IOException {
+ File file = new File(fileDir);
+ if (!file.exists()) {
+ LOG.error("{} is no existed", fileDir);
+ return;
+ }
+ try (FileWriter writer = new FileWriter(file, true);
+ BufferedWriter bw = new BufferedWriter(writer)) {
+ for (String string : strings) {
+ bw.write(string);
+ bw.newLine();
+ bw.flush();
+ }
+ }
+ }
+
+ public static void writeFileByLine(String fileDir, String string)
throws IOException {
--- End diff --
will refactor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
