Github user jerrypeng commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1053#discussion_r52079760
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
    @@ -301,7 +303,9 @@
             (try
               (rmpath (ConfigUtils/workerPidPath conf id pid))
               (catch Exception e)))) ;; on windows, the supervisor may still 
holds the lock on the worker directory
    -    (try-cleanup-worker conf id))
    +    (try-cleanup-worker conf id)
    +    (if (conf STORM-CGROUP-ENABLE)
    +      (.shutDownWorker (:cgroup-manager supervisor) id false)))
    --- End diff --
    
    will move to try-clean-up worker.  I don't think we need at to check for 
null since we set a default value for storm.resource.isolation.plugin config.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to