[
https://issues.apache.org/jira/browse/STORM-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137565#comment-15137565
]
ASF GitHub Bot commented on STORM-1226:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52216072
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -106,8 +158,23 @@
public static Object newInstance(String klass) {
try {
- Class c = Class.forName(klass);
- return c.newInstance();
+ LOG.info("Creating new instance for class {}", klass);
+ return newInstance(Class.forName(klass));
+ } catch (Exception e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ public static Object newInstance(Class klass) {
+ LOG.info("Inside other newInstance static method.");
+ return _instance.newInstanceImpl(klass);
+ }
+
+ // Non-static impl methods exist for mocking purposes.
+ public Object newInstanceImpl(Class klass) {
--- End diff --
This should be generic too, ideally.
> Port backtype.storm.util to java
> --------------------------------
>
> Key: STORM-1226
> URL: https://issues.apache.org/jira/browse/STORM-1226
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Reza Farivar
> Labels: java-migration, jstorm-merger
>
> Port backtype.storm.util from clojure to java. In as many instances as
> possible the same interface should be maintained, and calls to clojure
> functions in the rest of the code should be replaces with calls to the
> corresponding java code.
> Some similar functions can be found at
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/utils/JStormUtils.java
> Although they are not identical.
> For function callbacks we may need to evaluate adding in appropriate callback
> interfaces instead. Please try to avoid using clojure internal java classes
> unless necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
