[
https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141762#comment-15141762
]
ASF GitHub Bot commented on STORM-1272:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1095#discussion_r52531803
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -280,7 +281,7 @@
(defn- mk-disruptor-backpressure-handler [executor-data]
"make a handler for the executor's receive disruptor queue to
check highWaterMark and lowWaterMark for backpressure"
- (disruptor/disruptor-backpressure-handler
+ (DisruptorUtils/disruptorBackpressureHandler
--- End diff --
Could we just inline the impl here? There isn't much point in having this
translated to java when it is still so dependent on clojure.
> port backtype.storm.disruptor to java
> -------------------------------------
>
> Key: STORM-1272
> URL: https://issues.apache.org/jira/browse/STORM-1272
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Abhishek Agarwal
> Labels: java-migration, jstorm-merger
>
> wrapper around the disruptor queue. Might need some abstract base classes if
> it makes since.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
