[ 
https://issues.apache.org/jira/browse/STORM-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141764#comment-15141764
 ] 

ASF GitHub Bot commented on STORM-1272:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1095#discussion_r52531930
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
    @@ -302,12 +303,13 @@
             ]
         (disruptor/consume-loop*
           (:batch-transfer-queue executor-data)
    -      (disruptor/handler [o seq-id batch-end?]
    -        (let [^ArrayList alist (.getObject cached-emit)]
    -          (.add alist o)
    -          (when batch-end?
    -            (worker-transfer-fn serializer alist)
    -            (.setObject cached-emit (ArrayList.)))))
    +      (DisruptorUtils/clojureHandler
    --- End diff --
    
    Same here, lest just inline the implementation instead of translating 
something to java that depends on clojure.


> port backtype.storm.disruptor to java
> -------------------------------------
>
>                 Key: STORM-1272
>                 URL: https://issues.apache.org/jira/browse/STORM-1272
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Abhishek Agarwal
>              Labels: java-migration, jstorm-merger
>
> wrapper around the disruptor queue. Might need some abstract base classes if 
> it makes since.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to