[
https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143457#comment-15143457
]
ASF GitHub Bot commented on STORM-1248:
---------------------------------------
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1097#discussion_r52662027
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -487,11 +486,12 @@
)))))
(defn register-callbacks [worker]
- (log-message "Registering IConnectionCallbacks for " (:assignment-id
worker) ":" (:port worker))
- (msg-loader/register-callback (:transfer-local-fn worker)
- (:receiver worker)
- (:storm-conf worker)
- (worker-context worker)))
+ (let [transfer-local-fn (:transfer-local-fn worker)
+ ^IConnection socket (:receiver worker)]
+ (log-message "Registering IConnectionCallbacks for " (:assignment-id
worker) ":" (:port worker))
+ (.registerRecv socket (DeserializingConnectionCallback. (:storm-conf
worker)
--- End diff --
I am still not very convinced. I will port DeserializationCallBack to
clojure, then we will again port it back to java. IMO it will be better to make
it inline later, if needed.
@revans2 Since you wrote DeserializationCallback, was there any particular
reason for writing it outside worker.clj e.g. intending to use it in other
places?
> port backtype.storm.messaging.loader to java
> ---------------------------------------------
>
> Key: STORM-1248
> URL: https://issues.apache.org/jira/browse/STORM-1248
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Abhishek Agarwal
> Labels: java-migration, jstorm-merger
>
> Just a small bit of glue code for calling transfer-local-fn when messaging
> batch arrives.
> In the short term we may need to use an IFn, until the transfer-local-fn is
> migrated to java too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
