[
https://issues.apache.org/jira/browse/STORM-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154992#comment-15154992
]
ASF GitHub Bot commented on STORM-1556:
---------------------------------------
Github user ppoulosk commented on the pull request:
https://github.com/apache/storm/pull/1121#issuecomment-186433076
+1, NB
> nimbus.clj/wait-for-desired-code-replication wrong reset for
> current-replication-count-jar in local mode
> --------------------------------------------------------------------------------------------------------
>
> Key: STORM-1556
> URL: https://issues.apache.org/jira/browse/STORM-1556
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Jark Wu
> Assignee: Jark Wu
> Fix For: 1.0.0, 2.0.0
>
>
> https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/daemon/nimbus.clj#L520-L521
> {code}
> (if (not (ConfigUtils/isLocalMode conf))
> (reset! current-replication-count-conf (get-blob-replication-count
> (ConfigUtils/masterStormConfKey storm-id) nimbus)))
> (reset! current-replication-count-code (get-blob-replication-count
> (ConfigUtils/masterStormCodeKey storm-id) nimbus))
> (reset! current-replication-count-jar (get-blob-replication-count
> (ConfigUtils/masterStormJarKey storm-id) nimbus))))
> {code}
> We do not go to count the number of jar-replication in local mode, but will
> count the number of conf-replication. So is it a mistake that
> current-replication-count-conf and current-replication-count-jar in the wrong
> place?
> If it is a bug, I will create a PR soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
