[
https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168494#comment-15168494
]
John Fang commented on STORM-1279:
----------------------------------
I finished porting supervisor to java, but I want to get some more suggestions
about supervisor's class hierarchy. You can see the hierachy.
https://github.com/hustfxj/storm/tree/supervisor/storm-core/src/jvm/org/apache/storm/daemon/supervisor
SupervisorManger is supervisor' manger which can clean and shutdown
supervisor;
SyncSupervisorEvent is responsible for downloading/removing assignments
and topology files;
SyncProcessEvent is responsible for starting/killing workers;
SupervisorServer is responsible for starting up supervisor server;
SupervisorServer can start up local supervisor server as distributed server
does. Of course, SyncProcessEvent also can start workers in local mode. At the
same same, I will create localSupervisorServer.clj which are just for
launching a worker and downloading the jar in local mode. I can proxy
SyncProcessEvent and overridde launchLocalWorker by clojure at
localSupervisorServer.clj. It is similarify to proxy HttpServlet. As follows:
(proxy [HttpServlet] []
(service [request response]
((make-service-method handler)
this request response)))
localSupervisorServer.clj can be removed after porting worker.clj.
I hope someone can review my class hierarchy. [~abhishek.agarwal] [~revans2]
[~LongdaFeng]
> port backtype.storm.daemon.supervisor to java
> ---------------------------------------------
>
> Key: STORM-1279
> URL: https://issues.apache.org/jira/browse/STORM-1279
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: John Fang
> Labels: java-migration, jstorm-merger
> Attachments: Discussion about supervisor.pdf
>
>
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/daemon/supervisor
> as an example
> backtype.storm.event usage should be replaced with built-in java threadpools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
