Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-194443713
The code looks really good an I am +1 for merging it in as is. There are
still a few nits though. one with CommonInstaller and another that
@arunmahadevan pointed out for SystemTopologyBuilder that we need to come to a
resolution on.
Also you need to upmerge the drpc changes that went in have caused a minor
conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
