[ 
https://issues.apache.org/jira/browse/STORM-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190180#comment-15190180
 ] 

ASF GitHub Bot commented on STORM-1614:
---------------------------------------

Github user abellina commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1202#discussion_r55769202
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
    @@ -738,6 +738,7 @@
                         (run-worker-shutdown-hooks worker)
     
                         (.removeWorkerHeartbeat (:storm-cluster-state worker) 
storm-id assignment-id (long port))
    +                    (.removeWorkerBackpressure (:storm-cluster-state 
worker) storm-id assignment-id (long port))
    --- End diff --
    
    I tested submiting topologies and killing them and did not see issues do to 
this added line, but to those with more knowledge of backpressure logic please 
let me know if you can think of issues.


> Clean backpressure zk node in do-cleanup
> ----------------------------------------
>
>                 Key: STORM-1614
>                 URL: https://issues.apache.org/jira/browse/STORM-1614
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>            Reporter: Alessandro Bellina
>            Assignee: Alessandro Bellina
>            Priority: Minor
>
> Currently the backpressure node is being removed in killTopologyWithOpts in 
> nimbus. Remove instead like the other ZK nodes in do-cleanup for inactive 
> topos.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to