[ 
https://issues.apache.org/jira/browse/STORM-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191628#comment-15191628
 ] 

ASF GitHub Bot commented on STORM-1614:
---------------------------------------

Github user abellina commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1206#discussion_r55899966
  
    --- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
    @@ -73,6 +73,7 @@
       (teardown-topology-errors! [this storm-id])
       (heartbeat-storms [this])
       (error-topologies [this])
    +  (backpressure-topologies [this])
    --- End diff --
    
    I agree. I think, however, it is *somewhat* consistent with the interface 
(e.g. heartbeat-storms, error-topologies don't say get-X-topologies-id). 
Additionally, I think we should call them one thing throughout (is it storms? 
is it topologies? is it keys?) Happy to make that change, but I think it's 
bigger than this PR. Thoughts?


> Clean backpressure zk node in do-cleanup
> ----------------------------------------
>
>                 Key: STORM-1614
>                 URL: https://issues.apache.org/jira/browse/STORM-1614
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>            Reporter: Alessandro Bellina
>            Assignee: Alessandro Bellina
>            Priority: Minor
>
> Currently the backpressure node is being removed in killTopologyWithOpts in 
> nimbus. Remove instead like the other ZK nodes in do-cleanup for inactive 
> topos.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to