[
https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198180#comment-15198180
]
ASF GitHub Bot commented on STORM-1632:
---------------------------------------
Github user roshannaik commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-197551650
@abhishekagarwal87
This perf hit of 7-9% exists even if user does not enable logging from the
UI. With logging enabled, it should be even higher.
@arunmahadevan
The perf improvement i described here is observed when going from the
default value nil to 0 for topology.eventlogger.executors
**Topology detail:** 1 spout, 1 bolt, 1 acker. Spout generates random
numbers. Bolt does this math on the tuple: (value+1)*2. In effect this is
just a speed of light topology.
The perf hit that i noted is actually due to those very same checking of
flag.
This checking of flags in clojure turns into very expensive lookups in
clojure internals. It internally invokes Java reflection! If you are thinking
'what the hell'.. then yes that was my reaction too.
Specifically this is the problematic lookup for this code path :
'storm-component->debug-atom'
I agree with @arunmahadevan 's concern that this will confuse the users
when they don't see logs after enabling it on the UI.
The alternative fix for this is to change the manner in which this flag is
made available to the code. Basically make it more efficient.
There are some other lookups in the critical path that are also are causing
perf hits... which i plan to address in a separate jira.
> Disable event logging by default
> --------------------------------
>
> Key: STORM-1632
> URL: https://issues.apache.org/jira/browse/STORM-1632
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Roshan Naik
> Assignee: Roshan Naik
> Priority: Blocker
> Fix For: 1.0.0
>
>
> EventLogging has performance penalty. For a simple speed of light topology
> with a single instances of a spout and a bolt, disabling event logging
> delivers a 7% to 9% perf improvement (with acker count =1)
> Event logging can be enabled when there is need to do debug, but turned off
> by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
