[ 
https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198051#comment-15198051
 ] 

ASF GitHub Bot commented on STORM-1632:
---------------------------------------

Github user arunmahadevan commented on the pull request:

    https://github.com/apache/storm/pull/1217#issuecomment-197523828
  
    @roshannaik setting `topology.eventlogger.executors: 0` completely disables 
event logging by default (i.e. no threads are started to handle event logging). 
If someone tries to turn on event logging in the topology, they wont see any 
events logged and this is a very confusing behavior in my opinion. It makes 
them think that this functionality is totally broken or something is wrong with 
their topology. 
    
    The event logging happens only when they enable it and we don't expect them 
to turn it on all the time. The actual overhead otherwise is [to check if a few 
flags are turned 
on](https://github.com/apache/storm/blob/1.x-branch/storm-core/src/clj/org/apache/storm/daemon/executor.clj#L480).
 
    
    Can you post more details on the topology you ran and the results you 
observed when you set topology.eventlogger.executors to 0 vs setting it to 
`nil` ? 
    
    



> Disable event logging by default
> --------------------------------
>
>                 Key: STORM-1632
>                 URL: https://issues.apache.org/jira/browse/STORM-1632
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>            Reporter: Roshan Naik
>            Assignee: Roshan Naik
>            Priority: Blocker
>             Fix For: 1.0.0
>
>
> EventLogging has performance penalty. For a simple speed of light topology  
> with a single instances of a spout and a bolt, disabling event logging 
> delivers a 7% to 9% perf improvement (with acker count =1)
> Event logging can be enabled when there is need to do debug, but turned off 
> by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to