Github user arunmahadevan commented on the pull request:

    https://github.com/apache/storm/pull/1239#issuecomment-199648569
  
    @abhishekagarwal87 @harshach the changes looks good and putting the 
storm-sql jars in external/sql/storm-sql-core is consistent with other external 
modules whose jars are under external directory. 
    
    Question :- I don't see the storm-sql-kafka jar added to the `storm sql` 
classpath, so I am not sure how this would  be included in the topology jar or 
in the runtime.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to