Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1239#issuecomment-199989200
@revans2 The `storm sql` command (via the `StormSql` class) builds a fat
topology jar based on the class path, and submits it.
I have some concerns around this approach, as it seems brittle to me.
Specifically the code that builds the jar does not seem to be
resource/MANIFEST-aware (unlike the shade plugin). That worries me with respect
to Hadoop integration (*-site.xml, etc.). There's also the issue with having to
manually make the kafka jar available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
