[
https://issues.apache.org/jira/browse/STORM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208538#comment-15208538
]
ASF GitHub Bot commented on STORM-1650:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57173711
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -75,7 +76,7 @@
"Returns a function that returns a vector of which task indices to send
tuple to, or just a single task index."
[^WorkerTopologyContext context component-id stream-id ^Fields
out-fields thrift-grouping ^List target-tasks topo-conf]
(let [num-tasks (count target-tasks)
- random (Random.)
+ random (XORShiftRandom.)
--- End diff --
Again here the grouping could be called from multiple threads, but in this
case doubling up on some numbers should not be a big deal.
> improve performance by XORShiftRandom
> -------------------------------------
>
> Key: STORM-1650
> URL: https://issues.apache.org/jira/browse/STORM-1650
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: John Fang
> Assignee: John Fang
>
> '''Implement a random number generator based on the XORShift algorithm
> discovered by George Marsaglia. This RNG is observed 4.5 times faster than
> {@link Random} in benchmark, with the cost that abandon thread-safety. So
> it's recommended to create a new {@link XORShiftRandom} for each thread.'''
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
