[
https://issues.apache.org/jira/browse/STORM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209564#comment-15209564
]
ASF GitHub Bot commented on STORM-1650:
---------------------------------------
Github user roshannaik commented on the pull request:
https://github.com/apache/storm/pull/1250#issuecomment-200609948
My gut feeling based on profiling storm recently is that there are much
bigger bottlenecks elsewhere that will eclipse any potential improvement this
can deliver. I would recommend verifying with a simple and quantify the
performance improvement in throughput / latency this delivers.
Having said that, assuming it is a safe optimization, even if it does not
improve perf in the current code base, as other bottlenecks get addressed..
eventually this should help.
> improve performance by XORShiftRandom
> -------------------------------------
>
> Key: STORM-1650
> URL: https://issues.apache.org/jira/browse/STORM-1650
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: John Fang
> Assignee: John Fang
>
> '''Implement a random number generator based on the XORShift algorithm
> discovered by George Marsaglia. This RNG is observed 4.5 times faster than
> {@link Random} in benchmark, with the cost that abandon thread-safety. So
> it's recommended to create a new {@link XORShiftRandom} for each thread.'''
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
