Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/1217#issuecomment-201105956
  
    Yes, there is a performance hit. Especially in a single node cluster (don't 
know if you were running multiple workers), and networking doesn't come into 
play . I'm thinking of the big picture where you have multiple nodes. Then the 
numbers change, and it's not that big a hit.
    
    If we release with what we have now, I would leave things as is, and 
document that there's a performance benefit to turning it off. It's not hard to 
twiddle that flag.
    
    If we release as is, with this patch, the ui won't work as expected. Users 
will be confused, and anyone in a support role (I.e. Us) will be barraged with 
questions. And users will see a broken product.
    
    The performance hit here is also minor compared to the performance gain 
from simply upgrading to Krio 3.
    
    I think this is an important issue to address, but I don't think it's that 
big a deal that it should block the 1.0 release. We can address it better later 
in a minor release.
    
    Let's get 1.0 out the door.
    
    -1
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to