[
https://issues.apache.org/jira/browse/STORM-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215484#comment-15215484
]
ASF GitHub Bot commented on STORM-1662:
---------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1272#issuecomment-202723884
+1 if it's same to
https://github.com/arunmahadevan/storm/commit/7eae5ec9f63cee82c49980a3bedf5f0dfe4e3a8d.
I already applied this patch and test, and it looks good.
Btw, I may need to have dedicated server during test, cause when last
performance test for me this patch doesn't increase throughput when
eventlogger=1 but this patch **increase throughput when eventlogger=0**.
(Tested with roshan's topology, I didn't test with your topology. I can't
even work while benchmarking since I should run that for my work machine... ;( )
> event logger executors=1, origin
```
uptime: 540 duration: 30 secs
spout emitted: 24016500 (total: 420641440) emitted/sec (in duration):
800550.0
bolt emitted: 24016620 (total: 420639920) emitted/sec (in duration):
800554.0
uptime: 570 duration: 30 secs
spout emitted: 24392600 (total: 445034040) emitted/sec (in duration):
813086.6666666666
bolt emitted: 24392480 (total: 445032400) emitted/sec (in duration):
813082.6666666666
uptime: 600 duration: 30 secs
spout emitted: 24524700 (total: 469558740) emitted/sec (in duration):
817490.0
bolt emitted: 24524620 (total: 469557020) emitted/sec (in duration):
817487.3333333334
```
> event logger executors=0, origin
```
uptime: 541 duration: 30 secs
spout emitted: 27652560 (total: 441035220) emitted/sec (in duration):
921752.0
bolt emitted: 27653040 (total: 441034260) emitted/sec (in duration):
921768.0
uptime: 571 duration: 30 secs
spout emitted: 25150820 (total: 466186040) emitted/sec (in duration):
838360.6666666666
bolt emitted: 25150280 (total: 466184540) emitted/sec (in duration):
838342.6666666666
uptime: 601 duration: 30 secs
spout emitted: 25021760 (total: 491207800) emitted/sec (in duration):
834058.6666666666
bolt emitted: 25021860 (total: 491206400) emitted/sec (in duration):
834062.0
```
> event logger executors=1, applied arun's patch
```
uptime: 541 duration: 30 secs
spout emitted: 24319300 (total: 426107880) emitted/sec (in duration):
810643.3333333334
bolt emitted: 24319140 (total: 426106420) emitted/sec (in duration):
810638.0
uptime: 571 duration: 30 secs
spout emitted: 24394800 (total: 450502680) emitted/sec (in duration):
813160.0
bolt emitted: 24395420 (total: 450501840) emitted/sec (in duration):
813180.6666666666
uptime: 601 duration: 30 secs
spout emitted: 24425140 (total: 474927820) emitted/sec (in duration):
814171.3333333334
bolt emitted: 24424720 (total: 474926560) emitted/sec (in duration):
814157.3333333334
```
> event logger executors=0, applied arun's patch
```
uptime: 541 duration: 30 secs
spout emitted: 26572320 (total: 464465820) emitted/sec (in duration):
885744.0
bolt emitted: 26572680 (total: 464464560) emitted/sec (in duration):
885756.0
uptime: 571 duration: 30 secs
spout emitted: 26573580 (total: 491039400) emitted/sec (in duration):
885786.0
bolt emitted: 26573140 (total: 491037700) emitted/sec (in duration):
885771.3333333334
uptime: 601 duration: 30 secs
spout emitted: 26586520 (total: 517625920) emitted/sec (in duration):
886217.3333333334
bolt emitted: 26587000 (total: 517624700) emitted/sec (in duration):
886233.3333333334
```
Super odd result anyway, so I'd really like to see stable numbers.
> Reduce map lookups in send_to_eventlogger
> -----------------------------------------
>
> Key: STORM-1662
> URL: https://issues.apache.org/jira/browse/STORM-1662
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Arun Mahadevan
> Assignee: Arun Mahadevan
>
> Reducing map lookup in send_to_eventlogger can improve performance when when
> a spout emits in a tight loop.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
