[jira] [Commented] (STORM-1662) Reduce map lookups in send_to_eventlogger

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/STORM-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219624#comment-15219624
 ] 

ASF GitHub Bot commented on STORM-1662:
---------------------------------------

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/1272#issuecomment-203836195
  
    @arunmahadevan 
    I've just done with performance test, and the result is a bit different 
what I expected.
    
    
![eventlogger-performance-test-storm-1662-graph](https://cloud.githubusercontent.com/assets/1317309/14170745/35b77144-f76a-11e5-8fb7-22b959e7fcf0.png)
    
    This patch affects the performance even though event logger is set to 0 
thought I can't understand the result.
    This performance test is done with your topology + modification for logging 
performance.
    (https://gist.github.com/HeartSaVioR/0e2555633a5f7d12cb68)
    I restarted all Storm processes for every test.
    
    
[eventlogger-performance-test-STORM-1662-excel.xlsx](https://github.com/apache/storm/files/197260/eventlogger-performance-test-STORM-1662-excel.xlsx)
    
    Since test is done with my dev. machine (MBP), I really would like to 
borrow a dedicated machine and try this performance test again.


> Reduce map lookups in send_to_eventlogger
> -----------------------------------------
>
>                 Key: STORM-1662
>                 URL: https://issues.apache.org/jira/browse/STORM-1662
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>
> Reducing map lookup in send_to_eventlogger can improve performance when when 
> a spout emits in a tight loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)