Github user srdo commented on the pull request:
https://github.com/apache/storm/pull/1274#issuecomment-202845577
This doesn't really work. Shading Objenesis means that code with a
dependency on storm-core won't get a functional Kryo, since the transitive
dependency on Kryo refers to the original Objenesis package.
As far as I can tell, if we remove the objenesis exclusion from the Kryo
dependency and remove the shading, this should work like it did pre-upgrade. An
Objenesis jar will go in /lib, but since Kryo previously contained Objenesis
unshaded in the Kryo jar, it should work out to be the same as before.
Alternatively, we could also shade Kryo in order to get it off the
dependency reduced POM, so projects depending on storm-core won't pull Kryo as
a dependency of storm-core.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
