Github user srdo commented on the pull request:
https://github.com/apache/storm/pull/1274#issuecomment-202955987
@hustfxj Do you mean we should shade it? I don't understand why copying the
Objenesis code into Storm would improve things. If we put it in the original
package it's equivalent to just depending on the Objenesis jar. If we move it,
Kryo can't find it unless we use shading. If we shade it we also need to shade
Kryo in order for storm-core to work as a dependency during tests (otherwise we
declare a dependency on Kryo which depends on an unshaded Objenesis).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
