[
https://issues.apache.org/jira/browse/STORM-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218978#comment-15218978
]
ASF GitHub Bot commented on STORM-1667:
---------------------------------------
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1280
[STORM-1667] Log the IO exception when deleting worker pid dir
We find a race condition in supervisor which can sometimes crash supervisor.
This race condition exists because: shutdown-worker is called by both
sync-processes and synchronize-supervisor. One pid directory might have already
been deleted when rmr-as-user tries to delete it.
To avoid crashing the supervisor, we should log the exception rather than
throw it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm Storm-1667-1.x-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1280
----
commit c54162418a4a46d99ac360661f78cc5e10cb654a
Author: zhuol <[email protected]>
Date: 2016-03-30T22:21:41Z
[STORM-1667] Log the IO exception when deleting worker pid dir
----
> Log the IO Exception when deleting worker pid dir
> -------------------------------------------------
>
> Key: STORM-1667
> URL: https://issues.apache.org/jira/browse/STORM-1667
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: Zhuo Liu
> Assignee: Zhuo Liu
> Fix For: 1.0.0
>
>
> There is a race condition since shutdown-worker is called by both
> sync-processes and synchronize-supervisor in supervisor. One pid directory
> might have been already deleted when rmr-as-user tries to delete it.
> Therefore, we should not let the FileNotFoundException get thrown and crash
> the supervisor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
