[
https://issues.apache.org/jira/browse/STORM-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218980#comment-15218980
]
ASF GitHub Bot commented on STORM-1667:
---------------------------------------
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1280#discussion_r57974731
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -269,10 +269,7 @@
(catch IOException e
(log-warn-error e "Failed to cleanup worker " id ". Will retry later"))
(catch RuntimeException e
- (log-warn-error e "Failed to cleanup worker " id ". Will retry later")
- )
- (catch java.io.FileNotFoundException e (log-message (.getMessage e)))
--- End diff --
Delete redundant catch of FileNotFoundException since it has already been
caught as IOException
> Log the IO Exception when deleting worker pid dir
> -------------------------------------------------
>
> Key: STORM-1667
> URL: https://issues.apache.org/jira/browse/STORM-1667
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0
> Reporter: Zhuo Liu
> Assignee: Zhuo Liu
> Fix For: 1.0.0
>
>
> There is a race condition since shutdown-worker is called by both
> sync-processes and synchronize-supervisor in supervisor. One pid directory
> might have been already deleted when rmr-as-user tries to delete it.
> Therefore, we should not let the FileNotFoundException get thrown and crash
> the supervisor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
