[jira] [Commented] (STORM-1632) Disable event logging by default

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219478#comment-15219478
 ] 

ASF GitHub Bot commented on STORM-1632:
---------------------------------------

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/1217#issuecomment-203788623
  
    @roshannaik 
    Thanks for your quick reaction. 
    I applied your patch and verified that 1. topology.eventlogger.executors is 
0 at default 2. tooltip is shown when 'Debug' button is disabled, and it 
describes how to enable event logger.
    
    <img width="1106" alt="topology-eventlogger-tooltip-works" 
src="https://cloud.githubusercontent.com/assets/1317309/14167650/adbd7188-f757-11e5-95ae-5950777c4f08.png";>
    
    I'm also talking a look into #1272, but it's for improving performance when 
topology event logger > 0, not for blocking this.
    Thanks again for your patience. +1 overall for me.


> Disable event logging by default
> --------------------------------
>
>                 Key: STORM-1632
>                 URL: https://issues.apache.org/jira/browse/STORM-1632
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>            Reporter: Roshan Naik
>            Assignee: Roshan Naik
>            Priority: Blocker
>         Attachments: BasicTopology.java
>
>
> EventLogging has performance penalty. For a simple speed of light topology  
> with a single instances of a spout and a bolt, disabling event logging 
> delivers a 7% to 9% perf improvement (with acker count =1)
> Event logging can be enabled when there is need to do debug, but turned off 
> by default.
> **Update:** with acker=0  the observed impact was much higher... **25%** 
> faster when event loggers = 0 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)